Skip to content

fix(ourlogs): Fix top events for logs #93939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

fix(ourlogs): Fix top events for logs #93939

merged 2 commits into from
Jun 20, 2025

Conversation

colin-sentry
Copy link
Member

Also add a test, so that this doesn't happen again

@colin-sentry colin-sentry requested a review from a team as a code owner June 20, 2025 15:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❌ File not in storage

No result to display due to the CLI not being able to find the file.
Please ensure the file contains junit in the name and automated file search is enabled,
or the desired file specified by the file and search_dir arguments of the CLI.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93939   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files       10343    10343           
  Lines      597393   597420   +27     
  Branches    23217    23217           
=======================================
+ Hits       525908   525937   +29     
+ Misses      70981    70979    -2     
  Partials      504      504           

@colin-sentry colin-sentry merged commit 1a81517 into master Jun 20, 2025
64 checks passed
@colin-sentry colin-sentry deleted the ourlogs_top_n_test branch June 20, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants