Skip to content

fix(migrations): Patch broken saved search migrations #93944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

malwilley
Copy link
Member

Fixes getsentry/self-hosted#3766

This is what happened with the bad migrations:

  • 0917 was added, but it failed when running the post-deploy script
  • 0920 was added and checked for the missing owner ID, but also failed
  • 0921 was added and fixed another bug. This one succeeded

However, we never went back and removed the old failing migrations. Because they were post-deployment and never successfully run, I believe it's okay to make them noops.

@malwilley malwilley requested a review from a team as a code owner June 20, 2025 16:21
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2025
@malwilley malwilley requested a review from markstory June 20, 2025 16:24
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❌ File not in storage

No result to display due to the CLI not being able to find the file.
Please ensure the file contains junit in the name and automated file search is enabled,
or the desired file specified by the file and search_dir arguments of the CLI.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93944       +/-   ##
===========================================
+ Coverage   53.06%   88.03%   +34.96%     
===========================================
  Files       10334    10342        +8     
  Lines      596995   597414      +419     
  Branches    23222    23222               
===========================================
+ Hits       316824   525908   +209084     
+ Misses     279667    71002   -208665     
  Partials      504      504               

Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@malwilley malwilley merged commit 8a179d9 into master Jun 20, 2025
66 checks passed
@malwilley malwilley deleted the malwilley/fix/self-hosted-bad-migration-patching branch June 20, 2025 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrations error after 25.6.0 update
4 participants