ref(replay): Remove references to video filenames since videos are packed with recordings #93959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93959 +/- ##
==========================================
- Coverage 87.18% 85.62% -1.57%
==========================================
Files 10437 10373 -64
Lines 603191 601555 -1636
Branches 23493 23222 -271
==========================================
- Hits 525902 515087 -10815
- Misses 76925 85785 +8860
- Partials 364 683 +319 |
aliu39
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pack recordings and videos into a single file. >90 days ago we did not do this and had two separate files for each mobile replay. For this reason we had to delete two files for each replay segment. That is no longer necessary. Removing this second, unused filename from our delete operations will optimize its performance and remove legacy code from our code base.