Skip to content

ref(grouping): Small changes to grouping tests #93960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jun 20, 2025

This includes two small changes pulled out of an upcoming PR to make it easier to review:

  • Add some grouping inputs to illustrate the upcoming fix. Also rename a related input to better distinguish it from the new ones.

  • Add an assertion (currently failing for the new inputs) to show that we're not relying on chained exception error handling when filtering exception groups.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❌ File not in storage

No result to display due to the CLI not being able to find the file.
Please ensure the file contains junit in the name and automated file search is enabled,
or the desired file specified by the file and search_dir arguments of the CLI.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93960   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files       10350    10350           
  Lines      598214   598222    +8     
  Branches    23227    23227           
=======================================
+ Hits       526651   526674   +23     
+ Misses      71058    71043   -15     
  Partials      505      505           

@lobsterkatie lobsterkatie force-pushed the kmclb-small-grouping-test-changes-june-2025 branch from d12d4f7 to 95486b2 Compare June 20, 2025 18:55
@lobsterkatie lobsterkatie marked this pull request as ready for review June 20, 2025 20:19
@lobsterkatie lobsterkatie requested a review from a team as a code owner June 20, 2025 20:19
@lobsterkatie lobsterkatie merged commit dba5bc9 into master Jun 20, 2025
61 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-small-grouping-test-changes-june-2025 branch June 20, 2025 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants