Skip to content

fix(aci): Fix accidental over-logging #93971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

fix(aci): Fix accidental over-logging #93971

merged 1 commit into from
Jun 20, 2025

Conversation

kcons
Copy link
Member

@kcons kcons commented Jun 20, 2025

Unfortunately, 'event_data' went from being the variable for current event context to being the complete parsed data from Redis, and we continued logging it per group.
That's more data than we should be logging even arguably once, let alone per group.

@kcons kcons requested a review from a team as a code owner June 20, 2025 19:14
Copy link

sentry-io bot commented Jun 20, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/workflow_engine/processors/delayed_workflow.py

Function Unhandled Issue
fire_actions_for_groups SoftTimeLimitExceeded: SoftTimeLimitExceeded('SoftTimeLimitExceeded()\nSQL: SELECT "workflow_engine_detector"."id", "workflow_engine_detector"."date_updated", "workflow_engine_detector"."date_added", "workflow_engine_detector"."config", "workflow_engine_detector"."owner_user_... ...
Event Count: 11

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2025
Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop

@kcons kcons enabled auto-merge (squash) June 20, 2025 19:15
@kcons kcons merged commit b3f40e5 into master Jun 20, 2025
65 checks passed
@kcons kcons deleted the kcons/fixlog2 branch June 20, 2025 19:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants