Skip to content

Fix: Handle 'self' key collision in interface data #93972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seer-by-sentry[bot]
Copy link
Contributor

Fixes SENTRY-3YBF. The issue was that: Raw event data contained a context key 'self', conflicting with Python's implicit 'self' parameter during interface deserialization.

  • Prevents errors when an interface's data contains a key named 'self'.
  • Renames the 'self' key to 'payload_self' (or 'payload_self_N' if that already exists) to avoid conflicts with Python's implicit self parameter during object instantiation.

This fix was generated by Seer in Sentry, triggered by tillman.elser@sentry.io. 👁️ Run ID: 88200

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/interfaces/base.py 27.27% 8 Missing ⚠️

❌ Your patch check has failed because the patch coverage (27.27%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93972       +/-   ##
===========================================
+ Coverage   72.17%   88.09%   +15.92%     
===========================================
  Files       10295    10336       +41     
  Lines      593834   597285     +3451     
  Branches    23044    23044               
===========================================
+ Hits       428589   526192    +97603     
+ Misses     164796    70644    -94152     
  Partials      449      449               

@getsantry
Copy link
Contributor

getsantry bot commented Jul 12, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants