fix(grouping): Improve handling of known React 19 errors #93995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases in which we override the value of
main_exception_idin order to change which error in an exception chain we use for titling an event. In a well-formed chain, this works fine, but sometimes we see events which either a) have the root of a known chain but with nothing attached, or b) have a known chain root without amechanismvalue, and we don't handle those cases gracefully.This fixes that by a) only attempting the override if the event is in fact a chain, and b) checking for the
mechanismvalue before trying to look at it. It also adds some test cases illustrating that even if we see degenerate cases, the algorithm doesn’t crash.Fixes #93983
Fixes https://sentry.sentry.io/issues/6691472122