fix(taskworker) Add dimensions to memory_change metric #94000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd need taskname as a dimension to find which task was increasing memory usage.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94000 +/- ##
==========================================
- Coverage 88.02% 88.02% -0.01%
==========================================
Files 10349 10349
Lines 598482 598486 +4
Branches 23244 23244
==========================================
Hits 526822 526822
- Misses 71190 71194 +4
Partials 470 470 |
evanh
approved these changes
Jun 23, 2025
src/sentry/taskworker/workerchild.py
Outdated
| @@ -309,7 +309,9 @@ def _execute_activation(task_func: Task[Any, Any], activation: TaskActivation) - | |||
| origin="taskworker", | |||
| ) | |||
| with ( | |||
| track_memory_usage("taskworker.worker.memory_change"), | |||
| track_memory_usage( | |||
| "taskworker.worker.memory_change", tags={"taskname": activation.taskname} | |||
There was a problem hiding this comment.
Can we add namespace to this too?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd need taskname as a dimension to find which task was increasing memory usage.