Skip to content

feat(feedback): update frontend for AI summary panel #94001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025

Conversation

vishnupsatish
Copy link
Member

Updated based on designs

  • Error state was not updated, right now it just hides the box, should we surface an error to the user if there is one?

Loading state:
image

Too few feedback state:
image

  • Since, for now, there is no way to hide/collapse the box, removed the text that was below what we have now in the designs

@vishnupsatish vishnupsatish requested a review from a team as a code owner June 20, 2025 21:58
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jun 20, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@vishnupsatish vishnupsatish removed the Scope: Backend Automatically applied to PRs that change backend components label Jun 20, 2025
@vishnupsatish
Copy link
Member Author

Surfaced error state to users now, should it use <LoadingError/>? Felt like no because the loading state is now inside the box so removing the box and putting <LoadingError/> would be awkward. And putting <LoadingError/> inside the box would also be awkward.

@vishnupsatish vishnupsatish merged commit 4af0fc7 into master Jun 23, 2025
45 checks passed
@vishnupsatish vishnupsatish deleted the vishnupsatish/uf-summary-updated-frontend branch June 23, 2025 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants