Skip to content

feat(aci): Setup dataset, interval, aggregate function, filter #94002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 25, 2025

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Jun 20, 2025

Adds a dataset + interval dropdown.
Starts implementation for aggregate function heavily based on the new dashboard widget creation. On the form model itself the aggregate is stored as the full query function count_unique(user.id) and parsed into the fields. Some fields can get pretty complicated since some have multiple parameters or parameters are inputs instead of dropdowns.

Can't seem to get crash alerts working yet, might need examples of the expected payloads.

image

Adds a dataset + interval dropdown.
Starts implementation for aggregate function heavily based on the new dashboard widget creation.
@scttcper scttcper requested a review from a team as a code owner June 20, 2025 22:00
@scttcper scttcper marked this pull request as draft June 20, 2025 22:00
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 20, 2025
@scttcper scttcper changed the title feat(aci): Setup dataset, interval, aggregate function feat(aci): Setup dataset, interval, aggregate function, filter Jun 24, 2025
@scttcper scttcper marked this pull request as ready for review June 24, 2025 21:35
@scttcper scttcper requested review from malwilley and ameliahsu June 24, 2025 21:35
import {ErrorsConfig} from 'sentry/views/dashboards/datasetConfig/errors';
import {ReleasesConfig} from 'sentry/views/dashboards/datasetConfig/releases';
import {SpansConfig} from 'sentry/views/dashboards/datasetConfig/spans';
import {TransactionsConfig} from 'sentry/views/dashboards/datasetConfig/transactions';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense at some point to extract these to a folder outside of dashboards?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhhhhhh maybe

@scttcper scttcper merged commit 614f907 into master Jun 25, 2025
45 checks passed
@scttcper scttcper deleted the scttcper/detector-visualize branch June 25, 2025 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants