-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(aci): Setup dataset, interval, aggregate function, filter #94002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a dataset + interval dropdown. Starts implementation for aggregate function heavily based on the new dashboard widget creation.
malwilley
approved these changes
Jun 24, 2025
import {ErrorsConfig} from 'sentry/views/dashboards/datasetConfig/errors'; | ||
import {ReleasesConfig} from 'sentry/views/dashboards/datasetConfig/releases'; | ||
import {SpansConfig} from 'sentry/views/dashboards/datasetConfig/spans'; | ||
import {TransactionsConfig} from 'sentry/views/dashboards/datasetConfig/transactions'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense at some point to extract these to a folder outside of dashboards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhhhhhh maybe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dataset + interval dropdown.
Starts implementation for aggregate function heavily based on the new dashboard widget creation. On the form model itself the aggregate is stored as the full query function
count_unique(user.id)
and parsed into the fields. Some fields can get pretty complicated since some have multiple parameters or parameters are inputs instead of dropdowns.Can't seem to get crash alerts working yet, might need examples of the expected payloads.