Skip to content

Added reporting of VK_KHR_external_memory_fd vulkan extension as feature #7825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

SupaMaggie70Incorporated
Copy link
Contributor

@SupaMaggie70Incorporated SupaMaggie70Incorporated commented Jun 18, 2025

Connections

Description
Previously, in order to check for support of VK_KHR_external_memory_fd vulkan extension, one had to use as_hal and check the enabled extensions. However, VK_KHR_external_memory_win32 already reported this as a feature(even though both extensions are always enabled anyway). This PR brings that to VK_KHR_external_memory_fd.

Testing
No testing, very minimal changes

Squash or Rebase?
Both should be fine, as there is only one commit at the moment.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@cwfitzgerald
Copy link
Member

Could you rebase this to be independent, then we'll land it. Hopefully we can make it obsolete via #7829

@SupaMaggie70Incorporated
Copy link
Contributor Author

Could you rebase this to be independent, then we'll land it. Hopefully we can make it obsolete via #7829

Done!

@cwfitzgerald
Copy link
Member

Didn't seem to change anything, both commits are still visible?

@SupaMaggie70Incorporated
Copy link
Contributor Author

@cwfitzgerald Should be done now! Sorry, I'm a little clueless when it comes to git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants