HTMLRender interface: Instance method needs to return an error type #4210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
HTMLDebug
struct inrender/html.go
to returnnil
fromloadTemplate
instead of panicking when no files or glob patterns are provided. This change makes the behavior more robust and eliminates the need for external files in some test cases.Changes:
render/html.go
:loadTemplate
now returnsnil
instead of panicking whenFiles
andGlob
are empty.Render
handles anil
Template
gracefully by returningnil
.render/html_test.go
:TestHTMLDebugInstanceSuccess
andTestHTMLDebugInstanceNoFilesOrGlob
expect anil
Template
when no files are provided, avoiding file dependencies.render/render_test.go
:TestRenderHTMLDebugPanics
to expect anil
Template
instead of a panic, aligning with the new behavior.Motivation:
testdata/template.html
without requiring new files.Testing:
go test -v ./render/...
in thegin
repository.