Replace deprecated CloseNotify with Request.Context().Done() for better client disconnect detection #4217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Context.Stream function to use Request.Context().Done() instead of the deprecated CloseNotify() method.
Changes:
Replace w.CloseNotify() with c.Request.Context().Done() for client disconnect signal.
Motivation:
CloseNotify is deprecated and unreliable in modern HTTP/2 environments or when the connection passes through certain proxies or gateways.
Request.Context().Done() provides a more robust and standard-compliant way to detect client disconnects.
Impact:
This change improves compatibility and correctness, especially when using HTTP/2 or reverse proxies.
Let me know if you'd prefer backward compatibility logic for older Gin versions or if further changes are needed.