Skip to content

fix: Unwrap joinErr in gin.Error() #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Unwrap joinErr in gin.Error() #4260

wants to merge 1 commit into from
+50 −4

Conversation

arshukla98
Copy link

@arshukla98 arshukla98 commented Jun 7, 2025 •
edited
Loading

Issue Reference

Closes: #4237

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

Test Report

20250607_gin_tests_0790c13.pdf

Page 22 -> image

@arshukla98 arshukla98 marked this pull request as ready for review June 7, 2025 13:19
@arshukla98 arshukla98 marked this pull request as draft June 7, 2025 13:19
@arshukla98 arshukla98 marked this pull request as ready for review June 7, 2025 13:36
@arshukla98
Copy link
Author

Hi, I am ready for a PR review.

@arshukla98 arshukla98 force-pushed the Issue_4237 branch 2 times, most recently from e17500e to 0790c13 Compare June 9, 2025 06:26
@arshukla98
Copy link
Author

arshukla98 commented Jun 12, 2025 •
edited
Loading

Hi, I am ready for a PR review.

@arshukla98
Copy link
Author

Hi @appleboy , I would like to make a request to trigger the github action workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unwrap joinErr in gin.Error()
1 participant
@arshukla98