Skip to content

Add an option to fail on a skipped check #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adajou opened this issue Apr 8, 2025 · 4 comments
Open

Add an option to fail on a skipped check #384

adajou opened this issue Apr 8, 2025 · 4 comments
Labels
question Further information is requested or the issue is a question

Comments

@adajou
Copy link

adajou commented Apr 8, 2025

Details

We have a scenario where we want to skip a certain check for the development environment but not for stage and production. With the current setup (as I understand it from looking at the code here link) skipped check is considered healthy. It would be convient for us to have an option like skipped_checks: true/false (fail if it is set to false as we would like it to be here)

@adajou adajou added the question Further information is requested or the issue is a question label Apr 8, 2025
@GrantBirki
Copy link
Member

👋 Hey @adajou! Currently, all of the checks input options apply across all environments. There isn't a way to have a check be skipped in one environment, but not another.

I'm open to pull requests for this feature but it isn't something that I have immediate time to work on right now.

@adajou
Copy link
Author

adajou commented Apr 9, 2025

Hi @GrantBirki, thanks for the reply. I will take a look at the possibility of creating a PR for this

@GrantBirki
Copy link
Member

This pull request has some prior context as well: #337

@adajou
Copy link
Author

adajou commented Apr 10, 2025

This is what i'm using at the moment as a workaround. Passing all the checks needed for a specific environment. But having the ability to fail on skipped checks would make it much easier. I will propose a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested or the issue is a question
Projects
None yet
Development

No branches or pull requests

2 participants