Skip to content

Rust: upgrade rust-analyzer to 0.0.285 #19524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented May 19, 2025

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label May 19, 2025
@redsun82 redsun82 force-pushed the redsun82/cargo-upgrade-3 branch from cc2e8ab to 28b504a Compare May 26, 2025 14:21
@redsun82 redsun82 changed the title Rust: upgrade rust-analyzer to 0.0.279 Rust: upgrade rust-analyzer to 0.0.281 May 26, 2025
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QL changes LGTM.

I've raised some questions on the DCA run, it looks like a net gain but there are some regressions in there that deserve discussing.

Extractor changes not reviewed.

@redsun82 redsun82 changed the title Rust: upgrade rust-analyzer to 0.0.281 Rust: upgrade rust-analyzer to 0.0.285 Jun 4, 2025
@redsun82 redsun82 marked this pull request as ready for review June 4, 2025 12:12
@redsun82 redsun82 requested review from a team as code owners June 4, 2025 12:12
@aibaars
Copy link
Contributor

aibaars commented Jun 5, 2025

Looks good to me. The additional path resolution inconsistencies are a bit annoying though. Any idea where they come from?

@geoffw0
Copy link
Contributor

geoffw0 commented Jun 5, 2025

Judging by the second DCA run it looks like we're extracting significantly fewer files successfully as well - though the run did fail so I don't want to read too much into that.

@redsun82
Copy link
Contributor Author

redsun82 commented Jun 5, 2025

Don't know, there are still loads of unexpanded macros around :sigh:

@redsun82
Copy link
Contributor Author

redsun82 commented Jun 5, 2025

I've opened rust-lang/rust-analyzer#19931 (as I couldn't reopen rust-lang/rust-analyzer#19873).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants