Skip to content

Properly support "retired" QL tests #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbartol opened this issue Oct 27, 2020 · 1 comment
Open

Properly support "retired" QL tests #646

dbartol opened this issue Oct 27, 2020 · 1 comment
Labels
enhancement New feature or request VSCode

Comments

@dbartol
Copy link
Contributor

dbartol commented Oct 27, 2020

Is your feature request related to a problem? Please describe.
QL tests in the Test Explorer occasionally go into the "retired" state, where the test result icon is faded. There seems to be little rhyme or reason to when this happens.

Describe the solution you'd like
We should properly implement the retire event on the Test Adapter. It was added to Test Explorer after our original implementation, so it seems to use the default behavior of retiring all tests after any reload of the test tree, which we probably do whenever any file in a test directory changes.

Additional context
See here for some basic information about how the retire event is supposed to work.

@dbartol dbartol added the enhancement New feature or request label Oct 27, 2020
@aeisenberg
Copy link
Contributor

Going to jot down some notes of a slack discussion we had about this:

  1. We will need to delegate to the cli to determine what the dependencies of each test are. We will need to combine that with a filesystem watcher to retire/re-run any test whose dependencies change. It's unclear where these dependency files should live:
    a. alongside the tests. One file for each tree. In this case, we need to be careful that we don't accidentally commit these files to VCS.
    b. in workspace storage. This will keep these new files out of the workspace tree and will be less confusing for users. But, it will be more complex to maintain consistency between them and the tests.
  2. @dbartol also suggested we could store the expand/collapsed state of the test tree across restarts. We could store that inside of the test hierarchy, or in workspace storage. This is a separate, but related feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request VSCode
Projects
None yet
Development

No branches or pull requests

2 participants