Distribution is invalid after an upgrade

[aeisenberg]

Describe the bug

A bug was reported where a user upgraded and then was no longer able to run any codeql commands. On deeper inspection, we noticed that the path to the distribution was incorrect. The user was getting errors like:

Caused by: java.nio.file.NoSuchFileException: /Users/.../Library/Application Support/Code/User/globalStorage/github.vscode-codeql/distribution9/codeql/tools/codeql.jar

The actual distribution was located at .../distribution10/..., not .../distribution9/....

To reproduce

I haven't tried to reproduce, but suspect that the problem is the following:

1. Open two workspaces and ensure the installed version of the cli is outdated
2. Upgrade the cli versin in one of the workspaces
3. Do not upgrade in the other workspace
4. I think the non-upgraded workspace will still point to the old distribution even though it has been deleted.
   • It might be that you need to ensure the non-upgraded workspace has already initialized its codeql instance.
5. Now, doing anything codeql related in the non-upgraded workspace will cause the error.