Open
Description
Describe the bug
Relates to #297, #447
When a CodeQL CLI update is available the start of the extension is blocked until the user interacted with the update dialog, see:
vscode-codeql/extensions/ql-vscode/src/extension.ts
Lines 207 to 208 in db66184
However, personally I think the info dialog shown by VSCode is easy to miss, especially when there are other dialogs from other extensions (and VSCode collapses the CodeQL dialog?).
When you then overlook CodeQL's dialog, you will wonder why the extension is not working.
Version
Extension:
CodeQL extension version: 1.5.1
CodeQL CLI version: 2.5.7
Platform: win32 x64
VSCode:
Version: 1.57.1 (user setup)
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:07.755Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Windows_NT x64 10.0.19041
To reproduce
- Wait for the next CodeQL CLI release (maybe also possible with VSCode global storage manipulation)
- Start VSCode with the extension installed
- Activate the extension, for example by clicking on the "CodeQL" icon on the left sidebar
ℹ️ The extension should show an info dialog about the CodeQL CLI update in the bottom right corner - Ignore the update dialog (neither close it nor accept it)
- Try to use any extension action
❌ Nothing happens (note: from my memories; cannot test because there is no new CodeQL CLI release)
Expected behavior
Maybe the dialog should not be blocking and the extension should start with the existing CodeQL CLI?