Chore: Use get-vault-secrets without exporting env variables #1912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 📬 Triage
in Plugins Platform / Grafana Community
|
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
oshirohugo
added
the
no-changelog
oshirohugo
moved this from 📬 Triage
to 🔬 In review
in Plugins Platform / Grafana Community
academo
reviewed
Jun 20, 2025
|
|
||
| # As recommended on NX docs the NX Cloud token should be set as an environment variable: | ||
| # https://nx.dev/ci/recipes/security/access-tokens#setting-ci-access-tokens | ||
| - id: add-nx-cloud-access-token-to-env |
There was a problem hiding this comment.
I am not sure where we are invoking NX so asking just in case: can we better pass this as env to the step we are running nx instead of defining it globally here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Moves the usage of
get-vault-secretsto use step outputs instead of global env variablesWhich issue(s) this PR fixes:
Part of https://github.com/grafana/grafana-community-team/issues/427
Special notes for your reviewer:
The usages of
get-vault-secretsto get onlyNX_CLOUD_ACCESS_TOKENwhere not replaced becauseNX_CLOUD_ACCESS_TOKENneeds to be inenv