Skip to content

settings page does not reflect selected Theme #746

@hungryalgo

Description

@hungryalgo

Settings page is always light/white regardless of the Theme selected (Dark or Light).

Is this intentional or we just did not have time to respect the selected Theme?

If we need to fix this, how much work load do you expect? Just small change on the main settings page (settings/+layout.svelte) or do we need to change every UI piece in settings? I might want to fix this if this is not huge.

thanks

Activity

added
questionFurther information is requested
frontThis issue is related to the front-end of the app.
on Jan 29, 2024
nsarrazin

nsarrazin commented on Jan 29, 2024

@nsarrazin
Contributor

Yes i think for now that's by design, but I would like to fix it eventually. I think we need to start making components because it's a lot of tailwind classes everywhere atm.

added a commit that references this issue on Feb 5, 2024
85c44b6
linked a pull request that will close this issue on Feb 5, 2024
added 6 commits that reference this issue on Feb 6, 2024
be637cd
41f24b2
d00ecbb
851a7a4
d741c2a
9737ef1
added a commit that references this issue on Feb 14, 2024
a56a3c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    frontThis issue is related to the front-end of the app.questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @hungryalgo@nsarrazin

      Issue actions

        settings page does not reflect selected Theme · Issue #746 · huggingface/chat-ui