Skip to content

feat: modal animations regardless of the platform  #28499

Not planned
@reslear

Description

@reslear

Prerequisites

  • I have read the Contributing Guidelines.
    I agree to follow the Code of Conduct.
    I have searched for existing issues that already include this feature request, without success.

Describe the Feature Request

for example to make md or ios animations regardless of the platform:

  1. solution - export default animations:
    refactor: exportable md animations for modal #28464
import { mdEnterModalAnimation, mdLeaveModalAnimation } from '@ionic/core'
<ion-modal :enter-animation="mdEnterModalAnimation" :leave-animation="mdLeaveModalAnimation" />
  1. add presets for attribute enter-animation and leave-animation:
//before 
((baseEl: any, opts?: any) => Animation)  undefined

// after 
((baseEl: any, opts?: any) => Animation)  'md' | 'ios'  undefined

Describe the Use Case

Describe Preferred Solution

No response

Describe Alternatives

No response

Related Code

No response

Additional Information

No response

Activity

self-assigned this
on Nov 9, 2023
liamdebeasi

liamdebeasi commented on Nov 9, 2023

@liamdebeasi
Contributor

Thanks for the report. I'm going to merge this with #24964 since they are trying to solve the same root problem.

removed their assignment
on Nov 9, 2023
ionitron-bot

ionitron-bot commented on Dec 9, 2023

@ionitron-bot

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

locked and limited conversation to collaborators on Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @liamdebeasi@reslear

      Issue actions

        feat: modal animations regardless of the platform · Issue #28499 · ionic-team/ionic-framework