test(angular): add ng20 test app #30507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
commented
Jun 23, 2025
| @@ -8,7 +8,7 @@ runs: | |||
| steps: | |||
| - uses: actions/setup-node@v4 | |||
| with: | |||
| node-version: 18 | |||
| node-version: 22.x | |||
There was a problem hiding this comment.
Angular 20 requires a minimal node version of 20. I verified that version 22 works with all the Angular test apps that we support. By updating it to 22.x, renovate will be able to update it when necessary instead of keeping it pinned.
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Angular 20 test app is using an unsupported Typescript version. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Angular 20 only supports Typescript 5.8+. I forgot to update it in an earlier [PR](#30507). - Upgraded TS to the proper version. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
There are tests apps for Angular 16, 17, 18, and 19 only. Angular 20 has been released and should be included.
What is the new behavior?
Does this introduce a breaking change?
Other information
N/A