Skip to content

feat(datetime): add divider to datetime-action-buttons #30509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 2, 2025

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Jun 23, 2025

Issue number: internal


What is the new behavior?

Now, the action buttons have a divider for improved readability.

Does this introduce a breaking change?

  • Yes
  • No

Other information

ionic preview

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd added the package: core @ionic/core package label Jun 23, 2025
Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2025 3:42pm

Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem quite right. Let me know if I'm missing something!

- update dividers color;
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me, assuming you get whatever's going on in the screenshot tests ironed out 💪

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 9a053f6 into next Jul 2, 2025
246 of 356 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-11884 branch July 2, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants