ARO ... define structures

[marek-veber]

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR is the first step in implementing ARO, based on this proposal (see #5605).

Special notes for your reviewer:

TODOs:

• squashed commits
• includes documentation
• adds unit tests
• cherry-pick candidate

Release note:

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nawazkh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @marek-veber!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @marek-veber. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mboersma]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 3.89610% with 148 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (1d97b87) to head (3691246).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
exp/controllers/arocluster_controller.go	0.00%	47 Missing ⚠️
exp/controllers/arocontrolplane_controller.go	0.00%	36 Missing ⚠️
exp/controllers/aromachinepool_controller.go	0.00%	35 Missing ⚠️
main.go	0.00%	22 Missing ⚠️
exp/api/v1beta1/arocontrolplane_types.go	33.33%	4 Missing ⚠️
exp/api/v1beta1/aromachinepool_types.go	33.33%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5671      +/-   ##
==========================================
- Coverage   53.20%   52.95%   -0.26%     
==========================================
  Files         272      278       +6     
  Lines       29583    29737     +154     
==========================================
+ Hits        15740    15746       +6     
- Misses      13023    13171     +148     
  Partials      820      820              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[marek-veber]

/test pull-cluster-api-provider-azure-verify

[k8s-ci-robot]

@marek-veber: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-verify	d711727	link	true	/test pull-cluster-api-provider-azure-verify
pull-cluster-api-provider-azure-capi-e2e	d711727	link	false	/test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-e2e-aks	d711727	link	true	/test pull-cluster-api-provider-azure-e2e-aks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.