Make e2e node log collection more self-sufficient #5710
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
| @@ -101,11 +101,13 @@ spec: | |||
| nodeRegistration: | |||
| kubeletExtraArgs: | |||
| cloud-provider: external | |||
| youwillfailtobootstrappleaseandthankyou: "" | |||
There was a problem hiding this comment.
This PR is [WIP] while I make sure that VMSS instances that fail to bootstrap really do get logs now.
There was a problem hiding this comment.
logs!
Jun 18 05:38:36.422585 capz-e2e-d2pftj-vmss-mp-0000000 kubelet[1551]: E0618 05:38:36.422433 1551 run.go:72] "command failed" err="failed to parse kubelet flag: unknown flag: --youwillfailtobootstrappleaseandthankyou"
and on windows:
E0618 06:13:42.140420 2456 run.go:72] "command failed" err="failed to parse kubelet flag: unknown flag: --youwillfailtobootstrappleaseandthankyou"
Reverted these template changes.
/retitle Make e2e node log collection more self-sufficient
There was a problem hiding this comment.
I see the not-intentionally-broken run also successfully grabbed logs from the VMSS flex machine pool. I think that covers all the bases.
|
/test pull-cluster-api-provider-azure-e2e-optional |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5710 +/- ##
=======================================
Coverage 52.84% 52.84%
=======================================
Files 278 278
Lines 29610 29610
=======================================
Hits 15647 15647
Misses 13146 13146
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
k8s-ci-robot
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-provider-azure-e2e-optional |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Collecting logs from VMSS instances currently relies on CAPI having set nodeRefs for those instances in order to map those to the underlying Azure resources. This means that when bootstrapping a VMSS node fails and no nodeRef is produced on the MachinePool, CAPZ is unable to collect the logs that would help determine why that happened, as seen in this run.
These changes undercut CAPZ by relying on as little of its functionality as possible to determine how to reach nodes in order to collect logs. This should help us gather logs even when things fail (which is when we need them the most).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: