-
Notifications
You must be signed in to change notification settings - Fork 17
Proposal for shader semantics #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is another proposal on how to implement semantic input in Clang, given DXIL & SPIR-V have drasticly different handlings, but some parts could be shared. Another proposal exists: llvm#112 which also suggest a sema change.
proposals/NNNN-input-semantics.md
Outdated
HLSLAnnotationAttr *Semantic; | ||
|
||
// Info about this field/scalar. | ||
DeclaratorDecl *Decl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be useful to handle the [[vk::location(X)]]
attribute. Would be handled later, on top of this.
Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review of comments, thanks for all this work!
Thanks, rephrased mostly as suggested, reorganized a bit and added more intermediate examples, should be clearer |
This is another proposal on how to implement semantic input in Clang, given DXIL & SPIR-V have drasticly different handlings, but some parts could be shared.
The POC for this implementation is in llvm/llvm-project#149363
Another proposal exists: #112 which also suggest a sema change.