Skip to content

adjust default fusionauth provider details #10868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alex-fusionauth
Copy link
Contributor

@alex-fusionauth alex-fusionauth commented May 9, 2024

☕️ Reasoning

Adjusting defaults for FusionAuth provider.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Jun 27, 2025 0:44am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2025 0:44am

@github-actions github-actions bot added providers core Refers to `@auth/core` labels May 9, 2024
Copy link

vercel bot commented May 9, 2024

@codercatdev is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 205 lines in your changes missing coverage. Please review.

Project coverage is 38.76%. Comparing base (d7859d4) to head (45d1a87).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/providers/fusionauth.ts 0.00% 205 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10868      +/-   ##
==========================================
- Coverage   39.00%   38.76%   -0.25%     
==========================================
  Files         200      200              
  Lines       32122    32322     +200     
  Branches     1400     1399       -1     
==========================================
  Hits        12529    12529              
- Misses      19593    19793     +200     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alex-fusionauth
Copy link
Contributor Author

@ThangHuuVu let me know if there is anything else that needs to be adjusted for this. I don't see a clear way to pass the codecov tests for this change.

Copy link

stale bot commented Jan 31, 2025

It looks like this issue did not receive any activity for 60 days. It will be closed in 7 days if no further activity occurs. If you think your issue is still relevant, commenting will keep it open. Thanks!

@stale stale bot added the stale Did not receive any activity for 60 days label Jan 31, 2025
@stale stale bot removed the stale Did not receive any activity for 60 days label Feb 3, 2025
@alex-fusionauth
Copy link
Contributor Author

alex-fusionauth commented Feb 5, 2025

@falcowinkler thanks for approving, I actually have a follow up that adds in even more functionality if possible?

#10867

Has more of a breakdown with refresh tokens we would expect.

@falcowinkler
Copy link
Collaborator

@alex-fusionauth ok, just add the changes to this PR and we will check it out :)

@alex-fusionauth
Copy link
Contributor Author

@falcowinkler lmk if you need a fusionauth instance or anything to try this out on.

@alex-fusionauth
Copy link
Contributor Author

okay @falcowinkler it should be all set, I don't see a way in the provider to also set the callbacks, so I just added it to the details.

@mrjasonroy
Copy link

any way we can get this updated and merged into the main branch? Happy to help test or update

@alex-fusionauth
Copy link
Contributor Author

@falcowinkler I have updated this again to see if we can get merged, can you authorize?

@falcowinkler falcowinkler merged commit 3281854 into nextauthjs:main Jun 30, 2025
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants