Skip to content

fix(docs): svelte 5 compatibility updates #12634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

nicolecomputer
Copy link
Contributor

☕️ Reasoning

These were changes I needed to make while working through the docs with a new Svelte 5 app.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Jul 2, 2025 2:07pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2025 2:07pm

Copy link

vercel bot commented Feb 9, 2025

@nicolecomputer is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change requested, but otherwise looks good for Svelte 5 compat 🙏

@@ -55,7 +55,7 @@ import {
} from "drizzle-orm/pg-core"
import postgres from "postgres"
import { drizzle } from "drizzle-orm/postgres-js"
import type { AdapterAccountType } from "next-auth/adapters"
import type { AdapterAccountType } from "@auth/core/adapters";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should never have to install / interact with @auth/core as a consumer of these libraries.

Could you not get the AdapterAccountType type from @auth/sveltekit/adapters? If not, then that's a bug that should be fixed - let me know 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's not there. Here's the error message: Cannot find module '@auth/sveltekit/adapters' or its corresponding type declarations.ts(2307)

From my package.json:

    "@auth/sveltekit": "^1.7.4",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed this as a bug: #12649

@ndom91 ndom91 changed the title Doc fixes for Svelte fix(docs): svelte 5 compatibility updates Feb 12, 2025
@nicolecomputer
Copy link
Contributor Author

IT seems like isn't needed/wanted right now. I'm going to close soon unless someone pipes up to support this

@ndom91 ndom91 reopened this Jul 2, 2025
Fixup previous reference to next-auth
Update code for svelte 5
@ndom91 ndom91 merged commit 3b1b1b9 into nextauthjs:main Jul 2, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants