Skip to content

tools: include toolchain.gypi in abseil.gyp #58678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

tools: include toolchain.gypi in abseil.gyp #58678

merged 1 commit into from
Jun 20, 2025

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jun 11, 2025 •
edited
Loading

This sets proper SIMD build flags for abseil on ia32. Also moves include_dirs of V8_ROOT from toolchain.gyp to v8.gyp as it is mainly for V8 targets.

Fixes: #58569

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Jun 11, 2025
@legendecas legendecas marked this pull request as draft June 11, 2025 14:17
pld-gitsync pushed a commit to pld-linux/nodejs that referenced this pull request Jun 17, 2025
@jpalus
upstream fix to correct flags used for internal abseil
d380d6b 
from: nodejs/node#58678
fixes: nodejs/node#58569
regressed by: nodejs/node#57982
@legendecas
Copy link
Member Author

I don't think we have CI coverage on the reported platforms in #58569 as they are not supported. This patch could still be a good addition as this sets up proper build flags.

@legendecas legendecas marked this pull request as ready for review June 19, 2025 10:12
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67526/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67531/

targos
targos reviewed Jun 19, 2025
View reviewed changes
@legendecas
tools: include toolchain.gypi in abseil.gyp
733d872 
This sets proper SIMD build flags for abseil on ia32.
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67533/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6619/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6619/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6619/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67541/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67546/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67550/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67557/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4623d46 into nodejs:main Jun 20, 2025
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4623d46

@legendecas legendecas deleted the v8-gyp-abseil branch June 20, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node 22.16.0 on OpenBSD: building a module with node-gyp spins in a tight loop
3 participants
@legendecas @nodejs-github-bot @targos