Skip to content

fs: make Dir disposers idempotent #58692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

fs: make Dir disposers idempotent #58692

merged 1 commit into from
Jun 20, 2025

Conversation

Renegade334
Copy link
Contributor

As per draft explicit resource management guidelines (#58526) regarding disposer behaviour.

refs: #58206

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 12, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (5e1537c) to head (82fd894).
Report is 38 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58692      +/-   ##
==========================================
- Coverage   90.16%   90.14%   -0.03%     
==========================================
  Files         637      637              
  Lines      188098   188015      -83     
  Branches    36905    36891      -14     
==========================================
- Hits       169601   169478     -123     
- Misses      11231    11285      +54     
+ Partials     7266     7252      -14
Files with missing lines Coverage Δ
lib/internal/fs/dir.js 94.44% <100.00%> (-0.13%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67446/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit ce546e4 into nodejs:main Jun 20, 2025
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ce546e4

@Renegade334 Renegade334 deleted the fs-dir-idempotent-disposal branch June 20, 2025 19:30
RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025
@Renegade334 @RafaelGSS
fs: make Dir disposers idempotent
96c78d7 
PR-URL: #58692
Refs: #58206
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jun 23, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@lpinca lpinca

@Ethan-Arrowood Ethan-Arrowood

@bjohansebas bjohansebas

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Renegade334 @nodejs-github-bot @jasnell @lpinca @Ethan-Arrowood @bjohansebas