-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
test: deflake test-buffer-large-size-buffer-alloc #58734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
lpinca:deflake/test-buffer-large-size-buffer-alloc
Jun 18, 2025
Merged
test: deflake test-buffer-large-size-buffer-alloc #58734
nodejs-github-bot
merged 1 commit into
nodejs:main
from
lpinca:deflake/test-buffer-large-size-buffer-alloc
Jun 18, 2025
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use the error message as another condition to skip the test when the buffer allocation fails. Refs: nodejs@795dd8eb7988ae38553e Refs: nodejs@e9c6004a2d580008082b
6a9c2a7
to
8f1319a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58734 +/- ##
==========================================
- Coverage 90.15% 90.15% -0.01%
==========================================
Files 636 637 +1
Lines 187891 188121 +230
Branches 36879 36892 +13
==========================================
+ Hits 169386 169592 +206
+ Misses 11272 11266 -6
- Partials 7233 7263 +30 🚀 New features to boost your workflow:
|
juanarbol
approved these changes
Jun 16, 2025
StefanStojanovic
approved these changes
Jun 17, 2025
LiviaMedeiros
approved these changes
Jun 17, 2025
joyeecheung
approved these changes
Jun 17, 2025
Ethan-Arrowood
approved these changes
Jun 18, 2025
Landed in 214e4db |
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 23, 2025
Use the error message as another condition to skip the test when the buffer allocation fails. Refs: 795dd8eb7988ae38553e Refs: e9c6004a2d580008082b PR-URL: #58734 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This was referenced Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the error message as another condition to skip the test when the buffer allocation fails.
Refs: 795dd8eb7988ae38553e
Refs: e9c6004a2d580008082b