-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
lib: remove globalPreload support #58743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
Since the loader is now stable, the warning when using globalPreload is no longer necessary.
The globalPreload warning is no longer emitted, so the related test is removed.
970c7e7
to
f777eab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58743 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.04%
==========================================
Files 639 639
Lines 188201 188185 -16
Branches 36915 36914 -1
==========================================
- Hits 169675 169601 -74
- Misses 11274 11316 +42
- Partials 7252 7268 +16
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loaders aren't stable, but I think it's been enough time to remove.
In an abundance of caution though, perhaps let's mark this major?
Resolved TODO left at #49144.