Skip to content

feat(sdk-logs)!: Removed deprecated LoggerProvider#addLogRecordProcessor() #5764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Jun 25, 2025

Which problem is this PR solving?

Removed deprecated LoggerProvider#addLogRecordProcessor() in favor os the constructor option. See linked issue for more details.

Fixes #5738
Related PR: open-telemetry/opentelemetry-js-contrib#2895

Short description of the changes

  • Removed LoggerProvider#addLogRecordProcessor()
  • Updated exporters readme mention of adding this logger provider
  • Updated test
  • Removed addLogRecordProcessor from the contrib repos

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Updated test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

TODOs

  • Remove addLogRecordProcessor from contrib repo

@svetlanabrennan svetlanabrennan changed the title feat(sdk-logs)!: removed deprecated LoggerProvider#addLogRecordProcessor() feat(sdk-logs)!: Removed deprecated LoggerProvider#addLogRecordProcessor() Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (e18a6c8) to head (75d9869).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5764   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         303      303           
  Lines        7957     7950    -7     
  Branches     1609     1608    -1     
=======================================
- Hits         7560     7554    -6     
+ Misses        397      396    -1     
Files with missing lines Coverage Δ
...perimental/packages/sdk-logs/src/LoggerProvider.ts 100.00% <ø> (+2.22%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@svetlanabrennan svetlanabrennan marked this pull request as ready for review June 26, 2025 20:32
@svetlanabrennan svetlanabrennan requested a review from a team as a code owner June 26, 2025 20:32
@svetlanabrennan svetlanabrennan added this to the Logs API/SDK GA milestone Jun 26, 2025
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you 🙂

@pichlermarc pichlermarc added this pull request to the merge queue Jun 30, 2025
Merged via the queue into open-telemetry:main with commit 491ed96 Jun 30, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk-logs] remove deprecated LoggerProvider#addLogRecordProcessor()
3 participants