-
Notifications
You must be signed in to change notification settings - Fork 899
feat(sdk-logs)!: Removed deprecated LoggerProvider#addLogRecordProcessor()
#5764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-logs)!: Removed deprecated LoggerProvider#addLogRecordProcessor()
#5764
Conversation
LoggerProvider#addLogRecordProcessor()
LoggerProvider#addLogRecordProcessor()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5764 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 303 303
Lines 7957 7950 -7
Branches 1609 1608 -1
=======================================
- Hits 7560 7554 -6
+ Misses 397 396 -1
🚀 New features to boost your workflow:
|
experimental/packages/sdk-logs/test/common/LoggerProvider.test.ts
Outdated
Show resolved
Hide resolved
…brennan/opentelemetry-js into deprecate-addlogrecordprocessor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you 🙂
491ed96
Which problem is this PR solving?
Removed deprecated
LoggerProvider#addLogRecordProcessor()
in favor os the constructor option. See linked issue for more details.Fixes #5738
Related PR: open-telemetry/opentelemetry-js-contrib#2895
Short description of the changes
LoggerProvider#addLogRecordProcessor()
addLogRecordProcessor
from the contrib reposType of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated test
Checklist:
TODOs