-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update internal-telemetry.md #6799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I added some suggestions for clarity. Once we get the content ready, we can tackle the CI.
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
Signed-off-by: tiffany76 <30397949+tiffany76@users.noreply.github.com>
Signed-off-by: tiffany76 <30397949+tiffany76@users.noreply.github.com>
original `http*` and `rpc*` metric names with dots are preserved. The | ||
[internal metrics](#lists-of-internal-metrics) on this page are listed in their | ||
original form, such as`rpc.server.duration`. For more information, see the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've preemptively added this statement, but I can also remove it. @songy23 or @jade-guiton-dd, do you have any thoughts on whether we should change the http*
and rpc*
metrics to have dots in the list of metrics below?
Per this issue:
Created a new section on metric naming to clarify that some metrics have a suffix added as a result of the Prometheus exporter, and others have the dot replaced with an underscore.
Preview: https://deploy-preview-6799--opentelemetry.netlify.app/docs/collector/internal-telemetry/