Skip to content

docs: Update otel-diagram.svg as requested #6973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leandrocaracciolo
Copy link

@leandrocaracciolo leandrocaracciolo commented May 25, 2025

  • Updates the OpenTelemetry Collector architecture diagram (static/img/otel-diagram.svg) as requested.
  • Contributes to OTel intro rework #6486

Copy link

linux-foundation-easycla bot commented May 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: leandro-caracciolo (53db960)

@svrnm
Copy link
Member

svrnm commented May 26, 2025

thank you @leandro-caracciolo! Can you work with @jpkrohling to get the CLA signed?

@leandro-caracciolo
Copy link

thank you @leandro-caracciolo! Can you work with @jpkrohling to get the CLA signed?

Hi @svrnm . It's done!

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the diagram, but the SVG isn't editable by our OSS contributors who don't have access to Adobe software, including myself.

That is, the SVG contains about 4000 lines of CDATA:

<metadata>
    <i:aipgfRef id="adobe_illustrator_pgf"/>
    <i:aipgf id="adobe_illustrator_pgf" i:pgfEncoding="zstd/base64" i:pgfVersion="24">
<![CDATA[
KLUv/QBYVCQBmoh5RjCgSqaIHncdgxyEG6vqJV7YDUfPDZ57rt+GAwV+HhqtW9gkxVeeB+nYFF6H
lx9PYc5cBDQEWgTywQy+upQHo/S1q8qGvuPrwfhTGkso/ToU9Nc3O7rGN4FfffNH4ASL0p8fRonA
... [for about 4000 more lines]

This isn't editable without use of proprietary software.

@svrnm
Copy link
Member

svrnm commented May 28, 2025

@leandrocaracciolo thanks, the CLA is the first step:-)

Re @chalin's question: the image you shared on slack is editable, this seems to be a different export, can you double check on that?

@leandrocaracciolo leandrocaracciolo force-pushed the update-architecture-diagram-svg branch from e495393 to 61d493e Compare May 28, 2025 14:43
@leandro-caracciolo
Copy link

Hi @svrnm, thanks for the feedback! Yes, I've just pushed an updated version of the SVG (a5113854) that was re-exported using Inkscape (Plain SVG option). This should address the editability issue raised by @chalin and fix the prettier linting error. Please let me know if it looks better now.

@svrnm
Copy link
Member

svrnm commented Jun 5, 2025

That looks great @leandro-caracciolo !

@chalin
Copy link
Contributor

chalin commented Jun 5, 2025

The last time I had a quick check, I noticed that there is still a 3-4K CDATA entry. Can the be removed? Do we know what it is?

@chalin chalin force-pushed the update-architecture-diagram-svg branch from 61d493e to 53db960 Compare June 5, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants