-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[GPU] Add b_fs_yx_fsv16 fp16 onednn concatenation testcase #31140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[GPU] Add b_fs_yx_fsv16 fp16 onednn concatenation testcase #31140
Conversation
Signed-off-by: yuan.xiong <yuan.xiong@intel.com>
The added b_fs_yx_fsv16 & fp16 onednn concatenation testcase can be passed with older onednn gpu commit e7d51221ff8aa4698c4dd63fffc136ce7522ef62, but will be failed with new onednn gpu commit a42b47ff2cb81df552887dd4a3575f964386b25e (which is introduced into OpenVINO from d7f0f34). Note the onednn gpu commit change will not affect ocl concatenation, and this testcase can be passed when setting ocl implementation for concatenation. |
Note: CI test will be passed only when onednn concatenation issue is fixed.
|
ExecutionConfig cfg = get_test_default_config(engine); | ||
cfg.set_property(ov::intel_gpu::custom_outputs(std::vector<std::string>{ output_name })); | ||
cfg.set_property(ov::intel_gpu::force_implementations(ov::intel_gpu::ImplForcingMap{ {"concat", impl} })); | ||
network network(engine, topology, cfg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can implement it with less code.
- You can generate input random values from
tests::random_generator
- You can generate reference output by choosing cldnn impl and run the network as cldnn.
Reference:TEST(convolution_gpu_onednn, padding_for_cldnn_kernel_after_onednn)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isanghao, changed to use random input values and use ocl output as reference with commit 7f40e21.
Signed-off-by: yuan.xiong <yuan.xiong@intel.com>
Details:
Tickets: