Skip to content

[GPU] Add b_fs_yx_fsv16 fp16 onednn concatenation testcase #31140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yuanxion
Copy link
Contributor

@yuanxion yuanxion commented Jun 30, 2025

Details:

  • Add a b_fs_yx_fsv16 (& fp16) onednn concatenation testcases to verify onednn rls-3.9pc integration.

Tickets:

Signed-off-by: yuan.xiong <yuan.xiong@intel.com>
@yuanxion yuanxion requested review from a team as code owners June 30, 2025 03:41
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Jun 30, 2025
@yuanxion
Copy link
Contributor Author

The added b_fs_yx_fsv16 & fp16 onednn concatenation testcase can be passed with older onednn gpu commit e7d51221ff8aa4698c4dd63fffc136ce7522ef62, but will be failed with new onednn gpu commit a42b47ff2cb81df552887dd4a3575f964386b25e (which is introduced into OpenVINO from d7f0f34).

Note the onednn gpu commit change will not affect ocl concatenation, and this testcase can be passed when setting ocl implementation for concatenation.

@yuanxion
Copy link
Contributor Author

Note: CI test will be passed only when onednn concatenation issue is fixed.

INFO: [0;32m[ RUN      ] [mconcat_gpu_onednn.b_fs_yx_fsv16_input_types
INFO: src/plugins/intel_gpu/tests/unit/test_cases/concatenation_gpu_test.cpp:1756: Failure
INFO: Expected equality of these values:
INFO:   output_vec[x + offset_pad]
INFO:     Which is: 9584
INFO:   output_ptr[x]
INFO:     Which is: nan
INFO: [0;31m[  FAILED  ] [mconcat_gpu_onednn.b_fs_yx_fsv16_input_types (303 ms)
INFO: [0;32m[----------] [m1 test from concat_gpu_onednn (303 ms total)
INFO:
INFO: [0;32m[----------] [mGlobal test environment tear-down
INFO: [0;32m[==========] [m1 test from 1 test suite ran. (304 ms total)
INFO: [0;32m[  PASSED  ] [m0 tests.
INFO: [0;31m[  FAILED  ] [m1 test, listed below:
INFO: [0;31m[  FAILED  ] [mconcat_gpu_onednn.b_fs_yx_fsv16_input_types

ExecutionConfig cfg = get_test_default_config(engine);
cfg.set_property(ov::intel_gpu::custom_outputs(std::vector<std::string>{ output_name }));
cfg.set_property(ov::intel_gpu::force_implementations(ov::intel_gpu::ImplForcingMap{ {"concat", impl} }));
network network(engine, topology, cfg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can implement it with less code.

  • You can generate input random values from tests::random_generator
  • You can generate reference output by choosing cldnn impl and run the network as cldnn.
    Reference: TEST(convolution_gpu_onednn, padding_for_cldnn_kernel_after_onednn)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isanghao, changed to use random input values and use ocl output as reference with commit 7f40e21.

Signed-off-by: yuan.xiong <yuan.xiong@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants