Skip to content

Conversation

pdabre12
Copy link
Contributor

@pdabre12 pdabre12 commented Jun 23, 2025

Description

Expose plan checker router scheduler plugin counter Mbeans explicitly.

Motivation and Context

The java/ native redirect requests counters weren't exposed.

Impact

Users will be able to see the counters.

Test Plan

Screenshots attached

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jun 23, 2025
@pdabre12 pdabre12 force-pushed the expose-jmx-metrics branch 4 times, most recently from 97d2134 to 527470f Compare June 24, 2025 18:37
@pdabre12 pdabre12 changed the title Expose jmx metrics Expose plan checker router scheduler plugin counter Mbeans explicitly Jun 24, 2025
@pdabre12 pdabre12 marked this pull request as ready for review June 24, 2025 18:39
@pdabre12 pdabre12 requested review from a team as code owners June 24, 2025 18:39
@prestodb-ci prestodb-ci requested review from a team, NivinCS and jp-sivaprasad and removed request for a team June 24, 2025 18:39
@pdabre12 pdabre12 requested a review from steveburnett as a code owner June 24, 2025 19:45
steveburnett
steveburnett previously approved these changes Jun 24, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

@czentgr
Copy link
Contributor

czentgr commented Jul 10, 2025

@pdabre12 Please rebase, there are conflicts.

@pdabre12 pdabre12 force-pushed the expose-jmx-metrics branch 2 times, most recently from 51dd889 to db8d4f8 Compare July 16, 2025 16:54
Co-authored-by: unidevel <unidevel@hotmail.com>
@pdabre12 pdabre12 force-pushed the expose-jmx-metrics branch from db8d4f8 to fba255a Compare July 16, 2025 16:55
@pdabre12
Copy link
Contributor Author

pdabre12 commented Jul 16, 2025

Using jconsole, we can see the beans exposed locally:

Screenshot 2025-07-16 at 10 12 21 AM

@pdabre12 pdabre12 merged commit 7f9b3ed into prestodb:master Jul 17, 2025
115 checks passed
@pdabre12 pdabre12 deleted the expose-jmx-metrics branch July 17, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants