Remove second call of _updateWindowSize() #7847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
welp, the test action fails but not sure why as stated functionality hasn't been touched |
|
Hi @bensgilbert are the same tests failing if you remove the second call to |
* Fixed loop variable in createFileInput() docs (dom.js) * Bump serialize-javascript and mocha Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) to 6.0.2 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `serialize-javascript` from 6.0.0 to 6.0.2 - [Release notes](https://github.com/yahoo/serialize-javascript/releases) - [Commits](yahoo/serialize-javascript@v6.0.0...v6.0.2) Updates `mocha` from 10.2.0 to 10.8.2 - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md) - [Commits](mochajs/mocha@v10.2.0...v10.8.2) --- updated-dependencies: - dependency-name: serialize-javascript dependency-type: indirect - dependency-name: mocha dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * Bump elliptic from 6.6.0 to 6.6.1 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.6.0 to 6.6.1. - [Commits](indutny/elliptic@v6.6.0...v6.6.1) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * added instance of video in callback * Revert "fix: push() ignoring the ColorMode #7402" * Fix typos * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Add @dpanshug for doc * Update reference.js * Update reference.js.map * Update books.xml * Update error_helpers.js * Update sketch.js * Update sketch.js * Update p5.Table.js * Update p5.Image.js * Update pixels.js * Remove generated reference.js.map from PR * Restore generated file to match upstream main * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * 1.11.8 * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Andrew McWhae <andrew.mcwhae@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Soubhagya Mohapatra <ssm.allrounder@gmail.com> Co-authored-by: kit <1304340+ksen0@users.noreply.github.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: raclim <43053081+raclim@users.noreply.github.com> Co-authored-by: Perminder Singh <127239756+perminder-17@users.noreply.github.com> Co-authored-by: ksen0 <katie.kuksenok@gmail.com> Co-authored-by: sukrucildirr <sukrucildirr@gmail.com>
|
@ksen0 |
* Fixed loop variable in createFileInput() docs (dom.js) * Bump serialize-javascript and mocha Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) to 6.0.2 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `serialize-javascript` from 6.0.0 to 6.0.2 - [Release notes](https://github.com/yahoo/serialize-javascript/releases) - [Commits](yahoo/serialize-javascript@v6.0.0...v6.0.2) Updates `mocha` from 10.2.0 to 10.8.2 - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md) - [Commits](mochajs/mocha@v10.2.0...v10.8.2) --- updated-dependencies: - dependency-name: serialize-javascript dependency-type: indirect - dependency-name: mocha dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * Bump elliptic from 6.6.0 to 6.6.1 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.6.0 to 6.6.1. - [Commits](indutny/elliptic@v6.6.0...v6.6.1) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * added instance of video in callback * Revert "fix: push() ignoring the ColorMode #7402" * Fix typos * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Add @dpanshug for doc * Add stewards list and updating action * Udpate stewardship guidelines * Update steward_guidelines.md * Update stewards.yml * Update contributor_docs/steward_guidelines.md Co-authored-by: Dave Pagurek <dave@davepagurek.com> * Update contributor_docs/steward_guidelines.md Co-authored-by: Kenneth Lim <hello@limzykenneth.com> * Update contributor_docs/steward_guidelines.md Co-authored-by: Kenneth Lim <hello@limzykenneth.com> * Clarified to the stewardship responsibilities list * Update reference.js * Update reference.js.map * Update books.xml * Update error_helpers.js * Update sketch.js * Update sketch.js * Update p5.Table.js * Update p5.Image.js * Update pixels.js * Remove generated reference.js.map from PR * Restore generated file to match upstream main * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Fixes in guideline and new stewards * Add onboarding to steward guideline * 1.11.8 * Clean up stewards table generation * Update issue labeler to include new steward areas * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Respect p5.disableFriendlyErrors Respect `p5.disableFriendlyErrors` setting when overriding p5 global variables * Update stewards-update.yml to fix typo and include token * Added p5.js-website accessibility steward stewards.yml Adding @coseeian community as Web Accessibility Stewards for the p5.js-website * Enable workflow_dispatch trigger on stewards table update * Update stewards-update.yml to only make PR with README * Update README table from stewards.yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Andrew McWhae <andrew.mcwhae@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Soubhagya Mohapatra <ssm.allrounder@gmail.com> Co-authored-by: kit <1304340+ksen0@users.noreply.github.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: raclim <43053081+raclim@users.noreply.github.com> Co-authored-by: Perminder Singh <127239756+perminder-17@users.noreply.github.com> Co-authored-by: ksen0 <katie.kuksenok@gmail.com> Co-authored-by: Dave Pagurek <dave@davepagurek.com> Co-authored-by: Kenneth Lim <hello@limzykenneth.com> Co-authored-by: sukrucildirr <sukrucildirr@gmail.com> Co-authored-by: Quinton Ashley <quinton-ashley@users.noreply.github.com> Co-authored-by: ksen0 <ksen0@users.noreply.github.com>
davepagurek
approved these changes
Jun 19, 2025
|
@all-contributors please add @bensgilbert for code |
|
I've put up a pull request to add @bensgilbert! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
173e095 in #7785
accidently added a second call to
this._updateWindowSize();during initialisationthis function I added only needs to be called once
Trivial fix