-
Notifications
You must be signed in to change notification settings - Fork 340
Make icon links and link shortening optional #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
westurner
wants to merge
9
commits into
pydata:main
Choose a base branch
from
westurner:make_icon_links_optional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7b5cedd
BUG: do not add icon links if theme_options[icon_links] is None
westurner 2477db0
BUG: do not shorten links if theme_options['shorten_urls'] is not True
westurner 91c3609
[pre-commit.ci] Automatic linting and formatting fixes
pre-commit-ci[bot] 6947195
Revert "BUG: do not add icon links if theme_options[icon_links] is None"
gabalafou c6e83ee
respond to review by @drammock
gabalafou f4a03dd
Update src/pydata_sphinx_theme/__init__.py
gabalafou 97d93c4
test for shorten_urls=False in configuration
gabalafou 98087b5
Merge branch 'main' into make_icon_links_optional
gabalafou e97e91a
fix tests
gabalafou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<div class="github-container docutils container"> | ||
<p> | ||
<a class="reference external" href="https://github.com"> | ||
https://github.com | ||
</a> | ||
<a class="reference external" href="https://github.com/pydata"> | ||
https://github.com/pydata | ||
</a> | ||
<a class="reference external" href="https://github.com/pydata/pydata-sphinx-theme"> | ||
https://github.com/pydata/pydata-sphinx-theme | ||
</a> | ||
<a class="reference external" href="https://github.com/pydata/pydata-sphinx-theme/pull/1012"> | ||
https://github.com/pydata/pydata-sphinx-theme/pull/1012 | ||
</a> | ||
<a class="reference external" href="https://github.com/orgs/pydata/projects/2"> | ||
https://github.com/orgs/pydata/projects/2 | ||
</a> | ||
</p> | ||
</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<div class="gitlab-container docutils container"> | ||
<p> | ||
<a class="reference external" href="https://gitlab.com"> | ||
https://gitlab.com | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org"> | ||
https://gitlab.com/gitlab-org | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org/gitlab"> | ||
https://gitlab.com/gitlab-org/gitlab | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org/gitlab/-/issues/375583"> | ||
https://gitlab.com/gitlab-org/gitlab/-/issues/375583 | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org/gitlab/issues/375583"> | ||
https://gitlab.com/gitlab-org/gitlab/issues/375583 | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org/gitlab/-/issues/"> | ||
https://gitlab.com/gitlab-org/gitlab/-/issues/ | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org/gitlab/issues/"> | ||
https://gitlab.com/gitlab-org/gitlab/issues/ | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org/gitlab/-/issues"> | ||
https://gitlab.com/gitlab-org/gitlab/-/issues | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org/gitlab/issues"> | ||
https://gitlab.com/gitlab-org/gitlab/issues | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org/gitlab/-/merge_requests/84669"> | ||
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/84669 | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-org/gitlab/-/pipelines/511894707"> | ||
https://gitlab.com/gitlab-org/gitlab/-/pipelines/511894707 | ||
</a> | ||
<a class="reference external" href="https://gitlab.com/gitlab-com/gl-infra/production/-/issues/6788"> | ||
https://gitlab.com/gitlab-com/gl-infra/production/-/issues/6788 | ||
</a> | ||
</p> | ||
</div> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure why the default value in theme.conf isn't picked up by the test build process, but being forced to set
shorten_urls
to true also makes the setting more explicity.