Skip to content

Adds chunk key encoding to kwargs passed to zarr #10274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 10, 2025
Merged

Conversation

BrianMichell
Copy link
Contributor

@BrianMichell BrianMichell commented Apr 29, 2025

This PR aims to make chunk key encoding available for Zarr V2 arrays.

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

Accept chunk_key_encoding for Datasets and DataArrays

Add test

Add documentation for chunk key encoding
Copy link

welcome bot commented Apr 29, 2025

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@BrianMichell
Copy link
Contributor Author

I believe that this PR is ready for review, despite a flakey test failing this time around. I would be happy to make any additional updates that may be required!

@tasansal
Copy link

@shoyer @dcherian can you please review this if you have some time? We would like to merge this as quickly as possible.

@tasansal
Copy link

tasansal commented Jun 4, 2025

@TomNicholas can we please get an Xarray maintainer review this so it can be merged? Thank you very much :)

@BrianMichell
Copy link
Contributor Author

It would be very helpful to have this merged before the proposed v2025.06.0 release in #10406 as having / dimension separators available for new Zarr V2 datasets are required for our usecase.

@dcherian dcherian enabled auto-merge (squash) June 10, 2025 15:18
@dcherian dcherian merged commit 95a37d9 into pydata:main Jun 10, 2025
29 of 31 checks passed
Copy link

welcome bot commented Jun 10, 2025

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! celebration gif

dcherian added a commit to dcherian/xarray that referenced this pull request Jun 10, 2025
* upstream/main:
  Adds chunk key encoding to kwargs passed to zarr (pydata#10274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants