Downgrade zarr requests performance expectations for zarr 3.0.9 #10491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
added
topic-performance
upstream issue
topic-zarr
4 tasks
dcherian
reviewed
Jul 2, 2025
dcherian
approved these changes
Jul 2, 2025
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
|
OOC why do you use this custom approach rather than LoggingStore? |
ianhi
added a commit
to ianhi/xarray
that referenced
this pull request
Jul 2, 2025
….9 (pydata#10491)" This reverts commit 8d2e563.
|
This test predates the LoggingStore by many months, and its effectiveness prompted the addition of the |
|
We would gladly take a PR to use LoggingStore instead of mocks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explained and tracked upstream in zarr-developers/zarr-python#3199
cc @dcherian