Skip to content

Failed to migrate away from @import #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SukkaW opened this issue Mar 30, 2025 · 3 comments
Open

Failed to migrate away from @import #272

SukkaW opened this issue Mar 30, 2025 · 3 comments
Labels
bug Something isn't working needs info Awaiting a response with more info from the reporter

Comments

@SukkaW
Copy link

SukkaW commented Mar 30, 2025

$ sass-migrator module --migrate-deps src/styles/style.sass

Unhandled exception:
Bad state: Can't access _configuredVariables when not visiting a dependency.
#0      _ModuleMigrationVisitor._configuredVariables (package:sass_migrator/src/migrators/module.dart:190)
#1      _ModuleMigrationVisitor.visitVariableDeclaration (package:sass_migrator/src/migrators/module.dart:1185)
#2      VariableDeclaration.accept (package:sass/src/ast/sass/statement/variable_declaration.dart:87)
#3      RecursiveStatementVisitor.visitChildren (package:sass/src/visitor/recursive_statement.dart:107)
#4      ScopedAstVisitor.visitChildren.visit (package:sass_migrator/src/util/scoped_ast_visitor.dart:54)
#5      ScopedAstVisitor.visitChildren (package:sass_migrator/src/util/scoped_ast_visitor.dart:57)
#6      _ModuleMigrationVisitor.visitChildren (package:sass_migrator/src/migrators/module.dart:607)
#7      ScopedAstVisitor.visitStylesheet (package:sass_migrator/src/util/scoped_ast_visitor.dart:44)
#8      MigrationVisitor.visitStylesheet (package:sass_migrator/src/migration_visitor.dart:91)
#9      _ModuleMigrationVisitor.visitStylesheet (package:sass_migrator/src/migrators/module.dart:430)
#10     MigrationVisitor.run (package:sass_migrator/src/migration_visitor.dart:75)
#11     _ModuleMigrationVisitor.run (package:sass_migrator/src/migrators/module.dart:239)
#12     ModuleMigrator.migrateFile (package:sass_migrator/src/migrators/module.dart:104)
#13     Migrator.run (package:sass_migrator/src/migrator.dart:92)
#14     ModuleMigrator.run (package:sass_migrator/src/migrators/module.dart:64)
#15     CommandRunner.runCommand (package:args/command_runner.dart:212)
#16     MigratorRunner.execute (package:sass_migrator/src/runner.dart:95)
#17     main (file:///private/tmp/migrator-20250330-6741-sk81li/migrator-2.3.1/bin/sass_migrator.dart:17)
#18     _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:313)
#19     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:194)
@jathak
Copy link
Member

jathak commented Mar 31, 2025

Could you provide the Sass code being used here, or a reproduction that emits the same error? It shouldn't be possible for the migrator to get into this state, so I need to know what stylesheets are causing it to fix it.

@jathak jathak added bug Something isn't working needs info Awaiting a response with more info from the reporter labels Mar 31, 2025
@SukkaW
Copy link
Author

SukkaW commented Apr 1, 2025

Could you provide the Sass code being used here, or a reproduction that emits the same error? It shouldn't be possible for the migrator to get into this state, so I need to know what stylesheets are causing it to fix it.

Lemme see if I can extract a minimum reproduction!

@paskal
Copy link

paskal commented May 10, 2025

I have reproduction:

# git clone https://github.com/xianmin/hugo-theme-jane.git
# cd hugo-theme-jane
# git checkout 8f882af2a8dc2fffdd3a617f527685815e85541e
# npm install -g sass-migrator
# sass-migrator module --migrate-deps assets/sass/jane.scss
/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:5650
      throw error;
      ^

Bad state: Can't access _configuredVariables when not visiting a dependency.
    at Object.wrapException (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:1804:43)
    at Object.throwExpression (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:1823:15)
    at _ModuleMigrationVisitor.get$_configuredVariables (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:41823:29)
    at _ModuleMigrationVisitor.visitVariableDeclaration$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:42640:15)
    at VariableDeclaration.accept$1$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:27078:22)
    at VariableDeclaration.accept$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:27081:19)
    at _ModuleMigrationVisitor.visitChildren$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:39292:26)
    at ScopedAstVisitor_visitChildren_visit.call$0 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:44432:18)
    at _ModuleMigrationVisitor.visitChildren$2$withScope (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:44395:49)
    at _ModuleMigrationVisitor.visitChildren$2$withScope (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:42132:13) {
  dartException: <ref *1> StateError {
    message: "Can't access _configuredVariables when not visiting a dependency.",
    '$thrownJsError': <ref *2> Bad state: Can't access _configuredVariables when not visiting a dependency.
        at Object.wrapException (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:1804:43)
        at Object.throwExpression (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:1823:15)
        at _ModuleMigrationVisitor.get$_configuredVariables (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:41823:29)
        at _ModuleMigrationVisitor.visitVariableDeclaration$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:42640:15)
        at VariableDeclaration.accept$1$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:27078:22)
        at VariableDeclaration.accept$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:27081:19)
        at _ModuleMigrationVisitor.visitChildren$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:39292:26)
        at ScopedAstVisitor_visitChildren_visit.call$0 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:44432:18)
        at _ModuleMigrationVisitor.visitChildren$2$withScope (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:44395:49)
        at _ModuleMigrationVisitor.visitChildren$2$withScope (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:42132:13) {
      dartException: [Circular *1],
      '$cachedTrace': _StackTrace {
        _exception: [Circular *2],
        _trace: "Bad state: Can't access _configuredVariables when not visiting a dependency.\n" +
          '    at Object.wrapException (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:1804:43)\n' +
          '    at Object.throwExpression (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:1823:15)\n' +
          '    at _ModuleMigrationVisitor.get$_configuredVariables (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:41823:29)\n' +
          '    at _ModuleMigrationVisitor.visitVariableDeclaration$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:42640:15)\n' +
          '    at VariableDeclaration.accept$1$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:27078:22)\n' +
          '    at VariableDeclaration.accept$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:27081:19)\n' +
          '    at _ModuleMigrationVisitor.visitChildren$1 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:39292:26)\n' +
          '    at ScopedAstVisitor_visitChildren_visit.call$0 (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:44432:18)\n' +
          '    at _ModuleMigrationVisitor.visitChildren$2$withScope (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:44395:49)\n' +
          '    at _ModuleMigrationVisitor.visitChildren$2$withScope (/opt/homebrew/lib/node_modules/sass-migrator/sass-migrator.dart.js:42132:13)'
      }
    }
  }
}

Node.js v22.15.0

# sass-migrator --version
2.3.2 compiled with dart2js 3.7.3

# sass --version
1.87.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs info Awaiting a response with more info from the reporter
Projects
None yet
Development

No branches or pull requests

3 participants