Skip to content

Commit 67e965e

Browse files
committed
Build: Use one collective release step for all wheels, not just the ones from cibuildwheels.
1 parent 2b0bcca commit 67e965e

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

.github/workflows/wheels.yml

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,14 @@ jobs:
145145
name: wheel-${{ matrix.only }}
146146

147147
upload_release_assets:
148-
name: Upload Release Assets
149-
needs: [ build_wheels ]
148+
name: Upload Release Wheels
149+
needs: [ build_wheels, Linux, non-Linux ]
150150
runs-on: ubuntu-latest
151151
if: startsWith(github.ref, 'refs/tags')
152152

153+
permissions:
154+
contents: write # to create GitHub release (softprops/action-gh-release)
155+
153156
steps:
154157
- name: Download bdist files
155158
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
@@ -208,12 +211,6 @@ jobs:
208211
path: wheelhouse_*/*-m*linux*.whl # manylinux / musllinux
209212
if-no-files-found: ignore
210213

211-
- name: Release
212-
uses: softprops/action-gh-release@v1
213-
if: startsWith(github.ref, 'refs/tags/')
214-
with:
215-
files: wheelhouse_*/*-m*linux*.whl # manylinux / musllinux
216-
217214
non-Linux:
218215
strategy:
219216
# Allows for matrix sub-jobs to fail without canceling the rest
@@ -278,9 +275,3 @@ jobs:
278275
name: wheels-${{ matrix.pyversion }}-${{ matrix.os }}
279276
path: dist/*.whl
280277
if-no-files-found: ignore
281-
282-
- name: Release
283-
uses: softprops/action-gh-release@v1
284-
if: startsWith(github.ref, 'refs/tags/')
285-
with:
286-
files: dist/*.whl

0 commit comments

Comments
 (0)