Fix LT-21981: Pasted text retains writing system #368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added ReplaceExternalWritingSystems, which replaces writing systems in the pasted text that are not in cache.LanguageProject.AllWritingSystems with the writing system of the selection. This fixes the given test case.
This only works when PasteClipboard is called with an LcmCache argument. EditingHelper doesn't have its own LcmCache, and many of the places that create EditingHelper don't have their own LcmCache. EditingHelper.HandleOnKeyDown calls PasteClipboard without an LcmCache argument. I don't know when oftenHandleOnKeyDown is invoked.
This change is