refactor!: rewrite markdown-templates/step-feedback/step-results-table.md to Nunjucks syntax, remove required top-level passed argument
#70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FidelusAleksander
changed the title
markdown-templates/step-feedback/step-results-table.md to Nunjucks syntax, remove required top-level passed argument
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the step results table template by rewriting it in Nunjucks syntax and removing the required top-level passed argument.
- Replaces mustache templating with Nunjucks for conditional rendering and loops
- Introduces a computed variable (all_passed) to determine the overall step status
- Updates the tips and results table rendering accordingly
FidelusAleksander
added
breaking
arilivigni
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR ideally will be paired with a new release (
v3) of theskills/action-text-variablesthat will start usingNunjucksinstead ofmustache. A pull request is openChecklist