Skip to content

fix: Dumber fix for error assertions #13894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github commented Jun 17, 2025

fixes #13888

We've had issues in the past because isHttpError, isRedirect, and isActionFailure can start reporting false negatives when something somewhere decides to load two copies of the modules the classes are declared in. This switches to a tagged, structural approach that will survive these boundaries. The downside is that some library could throw { _tag: 'SvelteKitRedirect' } and isRedirect would report true, but... I mean, at that point, "hack the library at your own peril", I guess.

This would let us revert our prior attempt at externalizing dependencies, which has caused additional bugs.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 17, 2025

⚠️ No Changeset found

Latest commit: 65d0430

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eltigerchino eltigerchino linked an issue Jun 17, 2025 that may be closed by this pull request
@eltigerchino
Copy link
Member

eltigerchino commented Jun 17, 2025

There's some internal code as well that do not use these helpers and directly uses the instanceof check. We'd have to make changes there too to account for 3rd-party libraries throwing their own instances of these classes.

@svelte-docs-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvelteKit 2.21.3 Breaks Certain CommonJS Packages in Production
2 participants