-
Notifications
You must be signed in to change notification settings - Fork 559
[TOOL-4898] Dashboard: Replace PayEmbed with BuyWidget in asset page, add tracking #7459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-4898] Dashboard: Replace PayEmbed with BuyWidget in asset page, add tracking #7459
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BuyWidget
participant Analytics
User->>BuyWidget: Initiate buy
BuyWidget-->>Analytics: onError (if buy fails)
BuyWidget-->>Analytics: onSuccess (if buy succeeds)
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested reviewers
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (6)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7459 +/- ##
=======================================
Coverage 51.92% 51.92%
=======================================
Files 947 947
Lines 63932 63932
Branches 4216 4216
=======================================
Hits 33194 33194
Misses 30632 30632
Partials 106 106
🚀 New features to boost your workflow:
|
size-limit report 📦
|
8b1048e
to
82d1115
Compare
Merge activity
|
… add tracking (#7459) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `PayEmbed` component to `BuyWidget` in the `BuyTokenEmbed` function, enhancing the functionality with error reporting and success tracking for asset purchases. ### Detailed summary - Replaced `PayEmbed` with `BuyWidget` in `BuyTokenEmbed`. - Added `amount`, `chain`, and `className` props to `BuyWidget`. - Implemented `onError` and `onSuccess` callbacks for analytics reporting. - Updated the token address prop to ensure correct type. - Modified chart className in `contract-analytics.tsx`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Updated the buy token section to use an improved widget with enhanced error and success handling, including dynamic titles and analytics reporting. * **Style** * Adjusted the chart's aspect ratio for better display across different screen sizes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
82d1115
to
e814248
Compare
PR-Codex overview
This PR focuses on updating the
PayEmbed
component toBuyWidget
in theBuyTokenEmbed
function, enhancing functionality with error handling and analytics reporting for asset purchases.Detailed summary
PayEmbed
withBuyWidget
inBuyTokenEmbed
.amount
,chain
, andclassName
props toBuyWidget
.onError
and success reporting withonSuccess
.tokenSymbol
andtokenName
props fromBuyTokenEmbed
.Summary by CodeRabbit
New Features
Style