Skip to content

Commit 42c3f51

Browse files
committed
Fixed issue with circular references causing job schemas to be undefined
1 parent b304c2a commit 42c3f51

File tree

2 files changed

+26
-12
lines changed

2 files changed

+26
-12
lines changed

apps/webapp/app/v3/commonWorker.server.ts

Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,15 @@ import { Worker as RedisWorker } from "@trigger.dev/redis-worker";
33
import { DeliverEmailSchema } from "emails";
44
import { z } from "zod";
55
import { env } from "~/env.server";
6-
import {
7-
BatchProcessingOptions as RunEngineBatchProcessingOptions,
8-
RunEngineBatchTriggerService,
9-
} from "~/runEngine/services/batchTrigger.server";
6+
import { RunEngineBatchTriggerService } from "~/runEngine/services/batchTrigger.server";
107
import { sendEmail } from "~/services/email.server";
118
import { logger } from "~/services/logger.server";
129
import { singleton } from "~/utils/singleton";
1310
import { DeliverAlertService } from "./services/alerts/deliverAlert.server";
1411
import { PerformDeploymentAlertsService } from "./services/alerts/performDeploymentAlerts.server";
1512
import { PerformTaskRunAlertsService } from "./services/alerts/performTaskRunAlerts.server";
16-
import { BatchProcessingOptions, BatchTriggerV3Service } from "./services/batchTriggerV3.server";
17-
import {
18-
CancelDevSessionRunsService,
19-
CancelDevSessionRunsServiceOptions,
20-
} from "./services/cancelDevSessionRuns.server";
13+
import { BatchTriggerV3Service } from "./services/batchTriggerV3.server";
14+
import { CancelDevSessionRunsService } from "./services/cancelDevSessionRuns.server";
2115
import { CancelTaskAttemptDependenciesService } from "./services/cancelTaskAttemptDependencies.server";
2216
import { EnqueueDelayedRunService } from "./services/enqueueDelayedRun.server";
2317
import { ExecuteTasksWaitingForDeployService } from "./services/executeTasksWaitingForDeploy";
@@ -119,21 +113,40 @@ function initializeWorker() {
119113
},
120114
},
121115
"v3.cancelDevSessionRuns": {
122-
schema: CancelDevSessionRunsServiceOptions,
116+
schema: z.object({
117+
runIds: z.array(z.string()),
118+
cancelledAt: z.coerce.date(),
119+
reason: z.string(),
120+
cancelledSessionId: z.string().optional(),
121+
}),
123122
visibilityTimeoutMs: 60_000,
124123
retry: {
125124
maxAttempts: 5,
126125
},
127126
},
128127
"v3.processBatchTaskRun": {
129-
schema: BatchProcessingOptions,
128+
schema: z.object({
129+
batchId: z.string(),
130+
processingId: z.string(),
131+
range: z.object({ start: z.number().int(), count: z.number().int() }),
132+
attemptCount: z.number().int(),
133+
strategy: z.enum(["sequential", "parallel"]),
134+
}),
130135
visibilityTimeoutMs: 60_000,
131136
retry: {
132137
maxAttempts: 5,
133138
},
134139
},
135140
"runengine.processBatchTaskRun": {
136-
schema: RunEngineBatchProcessingOptions,
141+
schema: z.object({
142+
batchId: z.string(),
143+
processingId: z.string(),
144+
range: z.object({ start: z.number().int(), count: z.number().int() }),
145+
attemptCount: z.number().int(),
146+
strategy: z.enum(["sequential", "parallel"]),
147+
parentRunId: z.string().optional(),
148+
resumeParentOnCompletion: z.boolean().optional(),
149+
}),
137150
visibilityTimeoutMs: 60_000,
138151
retry: {
139152
maxAttempts: 5,

packages/redis-worker/src/queue.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ export class SimpleQueue<TMessageCatalog extends MessageCatalogSchema> {
203203
item: parsedItem,
204204
job: parsedItem.job,
205205
timestamp,
206+
availableJobs: Object.keys(this.schema),
206207
});
207208
continue;
208209
}

0 commit comments

Comments
 (0)