perf(next-swc): Remove needless JSON conversion

[kdy1]

What?

Remove JSON operations that are not required.

Why?

• perf(es/minifier): Remove needless JSON conversion swc-project/swc#10628
• minify Node binding wastes cycles performing string -> JSON -> string swc-project/swc#10610

How?

Closes PACK-4870

[ijjk]

Failing test suites

Commit: d48f478

pnpm test test/integration/server-side-dev-errors/test/index.test.js(rspack)

• server-side dev errors > should show server-side error for dynamic api route correctly

Expand output

● server-side dev errors › should show server-side error for dynamic api route correctly

expect(received).toStartWith(expected)

Expected string to start with:
  "⨯ ReferenceError: missingVar is not defined

  at handler (../../../test/integration/server-side-dev-errors/pages/api/blog/[slug].js:2:2)
      at"
  Received:
    "⚠ Fast Refresh had to perform a full reload due to a runtime error.
   ⨯ ReferenceError: missingVar is not defined
  at handler (../../../test/integration/server-side-dev-errors/pages/api/blog/[slug].js:2:2)
  at async Module.handler (../../packages/next/dist/build/webpack/loaders/next-route-loader/index.js?kind=PAGES_API&page=%2Fapi%2Fblog%2F%5Bslug%5D&preferredRegion=&absolutePagePath=.%2Fpages%2Fapi%2Fblog%2F%5Bslug%5D.js&middlewareConfigBase64=e30%3D!:100:0)
    1 | export default function handler(req, res) {
  > 2 |   missingVar;res.status(200).json({ slug: req.query.slug })
      |  ^
    3 | }
    4 | {
    page: '/api/blog/[slug]'
  }"
  at Object.toStartWith (integration/server-side-dev-errors/test/index.test.js:310:30)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/e2e/app-dir/segment-cache/revalidation/segment-cache-revalidation.test.ts

• segment cache (revalidation) > evict client cache when Server Action calls revalidatePath

Expand output

● segment cache (revalidation) › evict client cache when Server Action calls revalidatePath

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  50 |   })
  51 |
> 52 |   it('evict client cache when Server Action calls revalidatePath', async () => {
     |   ^
  53 |     let act: ReturnType<typeof createRouterAct>
  54 |     const browser = await next.browser('/', {
  55 |       beforePageLoad(page) {

  at it (e2e/app-dir/segment-cache/revalidation/segment-cache-revalidation.test.ts:52:3)
  at Object.describe (e2e/app-dir/segment-cache/revalidation/segment-cache-revalidation.test.ts:7:1)

Read more about building and testing Next.js in contributing.md.

[codspeed-hq]

CodSpeed Performance Report

Merging #80671 will not alter performance

_{Comparing kdy1/minify-json (d48f478) with canary (ac0888f)}

Summary

✅ 12 untouched benchmarks

[mischnic]

Why is this an option? What's the point in minifying if you don't pass any code to minify?

[kdy1]

We do get &mut self instead of self by the trait definition